search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Update AssumptionOfMaryTest.php #155

Closed pioc92 closed 5 years ago

stelgenhof commented 5 years ago

@pioc92 Thanks for the additions, however since you've created separate PR's for the unit tests, both the unit test and source code still fail. Source code changes/additions and unit tests should be submitted together.

Could you try correcting the PR's?

Thanks! Sacha

pioc92 commented 5 years ago

i have corrected the Pr's, maybe it's ok now. Sorry because i'm not very familiar with PR and unit tests submissions

stelgenhof commented 5 years ago

@pioc92 No problem. A PR should ideally be a complete package/change, which should include unit tests as well. :)