I noticed that there is no translation for substituteHoliday:secondChristmasDay in the UnitedKingdom provider. I realised that providing translations for substitute holidays is cumbersome, especially when using global translations.
With this PR, substitute holidays are promoted into a first-class citizen with the SubstituteHoliday class. It references the substituted holiday and can inherit the translations from that with an “observed” suffix appended, if the substitute holiday itself does not have an original name.
I noticed that there is no translation for
substituteHoliday:secondChristmasDayin theUnitedKingdomprovider. I realised that providing translations for substitute holidays is cumbersome, especially when using global translations.With this PR, substitute holidays are promoted into a first-class citizen with the
SubstituteHolidayclass. It references the substituted holiday and can inherit the translations from that with an “observed” suffix appended, if the substitute holiday itself does not have an original name.The idea of using
{0}as a placeholder is inherited from CLDR (see e.g. https://raw.githubusercontent.com/unicode-org/cldr/master/common/main/nl.xml).