azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Liberation Day is official in the Netherlands #169

Closed c960657 closed 5 years ago

c960657 commented 5 years ago

Liberation Day in the Netherlands is a public holiday, according to Wikipedia and Dutch law (not mentioned by named but referred to as fifth of May).

stelgenhof commented 5 years ago

As the notes on Wikipedia said, May the 5th is not mandatory paid off for everybody. That's perhaps why initially I marked it as 'OBSERVANCE'. But now thinking about it may be better to mark it as OFFICIAL indeed.

c960657 commented 5 years ago

The distinction between the different holiday types is difficult due to different traditions in each country.

Many countries have legislation containing an explicit list of holidays. In my understanding, these have TYPE_OFFICIAL. Whether these days are paid/non-paid days off is a different matter – this often depends on tradition, collective agreements. With respect to non-working days, legislation often covers only the public sector.

Often the legislation mentions other days that are not official holidays but in some contexts have the same status. E.g. article 3.1 in the Dutch law mentioned above mentions Good Friday as such a day. These are probably TYPE_OBSERVANCE.

I assume the official classification is not so relevant for users of Yasumi. Instead I assume they are more interested in – depending on the specific use-case – whether it is a regular working day, whether shops are open, whether banks are open, etc. I am not sure how to model this, but I have outlined some thoughts in #99.

stelgenhof commented 5 years ago

Yes correct. It may not always be easy to assign the proper indication. Furthermore the use-cases might be different for every user of Yasumi, so I tried to keep it as straightforward as possible (and think it should be that). For the moment this simple classification works but also understand and agree the proposal you made in #99 . I haven't yet properly thought about :(