search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Holiday provider for India #175

Closed c960657 closed 4 years ago

c960657 commented 5 years ago

New holiday provider with support for the 3 public holidays in India.

I was not able to figure out when these days were made official holidays, but at least they are limited by the year of the event they are commemorating.

stelgenhof commented 5 years ago

Nice! This only include the national holidays. Have you thought about the other, various religious holidays in India?

c960657 commented 5 years ago

I did think about it, and it is 100% relevant. But I'm afraid I don't have the time or need (or knowledge) to implement these.

There is a boatload of holidays for each of the large religions in India, so it is a considerable task. For my own purpose, I only need the official holidays, so I'll leave it there. Other developers are welcome to pick up this task and extend the provider.

If you don't want to merge this provider with only the official holidays, I totally understand.

stelgenhof commented 5 years ago

Thanks! Totally understand about the volume. However usually my criterium for adding a new country is when all (or nearly all) official / recognized holidays are included. This to give end-users a complete package, rather then a half implemented one :)

Let me have a think about it.

Thanks for the work anyway as always! Sacha

Milamber33 commented 5 years ago

Australia was far from complete before I fleshed it out...

stelgenhof commented 5 years ago

@Milamber33 Exceptions can be made ;)

Anyways... although Australia wasn't immediately complete indeed, it was when it became part of a release.

github-actions[bot] commented 4 years ago

This pull request has been open 30 days with no activity. Please remove the stale label or comment, or this will be closed in 5 days