search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

polish holidays & translation #18

Closed mpdx closed 8 years ago

stelgenhof commented 8 years ago

Thank you @mpdx ! Let me review the PR. Nice to have Poland added as well :)

stelgenhof commented 8 years ago

There is a basic test file missing for the country/region itself. It should be called PolandTest.php and needs to contain tests which holidays you are expecting from the provider class. Check the other countries for an example.

mpdx commented 8 years ago

@stelgenhof aye, mate! thanks for the info!

stelgenhof commented 8 years ago

It seems there is no unit test for Corpus Christi. Can you add that one too?