azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Fix issue if calculated workday is in next year #191

Closed tniemann closed 4 years ago

tniemann commented 4 years ago

Currently, the year of the calculated date is not changed if it is in the next year. When u try to get the next working day starting from 28.12.2019 and with 3 working days the calculated day is 1.1.2019 which is in the past.

stelgenhof commented 4 years ago

Thank you very much for the PR! Note that the checks failed as your branch is behind the current develop branch. You may want to do a rebase or merge.

tniemann commented 4 years ago
    Hey, sorry. I created a new PR.When do u think this will be in master and available via packagist? We use this library to calculate delivery dates which are all wrong at the moment!

Regards Thomas

On Sat, Dec 28, 2019 at 2:03 PM +0100, "Sacha Telgenhof" notifications@github.com wrote:

Thank you very much for the PR! Note that the checks failed as your branch is behind the current develop branch. You may want to do a rebase or merge.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.