Use typographical apostrophe

azuyalabs / yasumi

The easy PHP Library for calculating holidays

https://www.yasumi.dev

Other

1.05k stars 155 forks source link

Use typographical apostrophe #197

Closed c960657 closed 4 years ago

c960657 commented 4 years ago

Proper typography prefers a curly/typographic apostrophe ’ rather than a vertical/typewriter apostrophe, ' (see https://en.wikipedia.org/wiki/Apostrophe#Typographic_form). AFAICT this convention applies to all locales.

I suggest replacing all occurrences of typewriter apostrophe in translations with a typographical apostrophe.

Instead of editing all occurrences of Queen’s Birthday, I moved this to a separate translations file (and added a few translations based on Wikipedia).

stelgenhof commented 4 years ago

Thanks! I'll guess I'll start to make some proper contributor documentation: there are quite a number of 'requirements' when creating providers or updates.