search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Date addition (Australia Day Subdivision: AU-SA / Year: 2020) #199

Closed jbroudou closed 4 years ago

jbroudou commented 4 years ago

It appears from https://www.safework.sa.gov.au/law-compliance/laws-regulations/public-holidays that in 2020 in South Australia, 2020-01-26 (Sunday) and 2020-01-27 (Monday) are both "Australia Day" public holidays. See specifically footnote 1 on this website which states: "If a Saturday, normal rates apply and the following Monday is the public holiday. If a Sunday, that and the following Monday are both public holidays."

Your project is currently only recording 2020-01-27 (Monday) as Australia Day.

It would be great if you could add the additional Sunday.

stelgenhof commented 4 years ago

Thanks for spotting this one. Although in the code a substitution is performed, it actually overwrites the original holiday resulting the original one not to be present. The code for Australia needs a bit of rework as it doesn't apply the SubstituteHoliday class that recently was introduced.

github-actions[bot] commented 4 years ago

This issue has been open 30 days with no activity. Please remove the stale label or comment, or this will be closed in 5 days