search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Update translation for fr_LU and fr_CA #211

Closed c960657 closed 4 years ago

c960657 commented 4 years ago

Update the French translation for Second Christmas Day for Luxembourg and Canada.

Credits to @Arkounay for his insights on this.

Quote from https://github.com/azuyalabs/yasumi/pull/188#issuecomment-598901208:

I remember we spoke about this at work and picked "Lendemain de Noël" as a translation because the majority of us said that naturally and an app we use translated it as so.

I think the app we use is based from this website, where it's translated as "Lendemain de Noël" for Luxembourg : https://www.joursferies.fr/pays/luxembourg.php

However, if we check the homepage (https://www.joursferies.fr/) when it comes to France it's indeed translated as Saint-Étienne too there. Since these regions in France are close to Luxembourg, I thought that day had the same name.

So you're right, Saint-Étienne is the proper term in France. I'm sorry for the mistake!

  • For the fr locale we should definitely translate it as "Saint-Étienne"
  • However for fr_lu I'd change it into "Deuxième jour de Noël" as it seems it's the official term there

I've checked official Luxembourg websites and there it's translated as translated as "Deuxième jour de Noël" : https://luxembourg.public.lu/fr/vivre/qualite-de-vie/jours-feries-legaux.html https://itm.public.lu/fr/conditions-travail/conges/jours-feries.html (I think these two websites are worth more than banquedeluxembourg.com since the public.lu domain is reserved for the government)