search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Add accessors for shortName and substitutedHoliday #220

Closed c960657 closed 4 years ago

c960657 commented 4 years ago

Accessing public properties directly is bad practice and makes refactorings difficult.

This PR adds accessor methods for $holiday->shortName and $substituteHoliday->substitutedHoliday and deprecates direct access to those two properties.

stelgenhof commented 4 years ago

That is definitely not the right way :) Thanks for the fix!

c960657 commented 4 years ago

Done :-)