search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Spain and Catalonia: Valentine's day is not holiday #234

Closed jroman14 closed 3 years ago

jroman14 commented 3 years ago

Hi mate, valentin day is not holiday in spain and catalonia. Can you update that?

Thanks for your job

sachatelgenhof commented 3 years ago

Hi, Valentine's Day is indeed in most countries not an official holiday. For Spain it is classified as 'OTHER' meaning not an official holiday. Do you have a particular issue when using Yasumi for Spain?

jroman14 commented 3 years ago

Hi I'm using getHolidayDates function to save in internal calendar. Then valentines days appear as holiday. There are any method to filter days classified as Other? Thank you again!

stelgenhof commented 3 years ago

Yes, you can use filters for that. Have a look at the documentation here: https://www.yasumi.dev/docs/cookbook/filters/ The OfficialHolidays filter will exactly do what you need.

Cheers! Sacha

github-actions[bot] commented 3 years ago

This issue has been open 60 days with no activity. Please remove the stale label or comment, or this will be closed in 10 days.