Working tests on php8 - Githubissues

azuyalabs / yasumi

The easy PHP Library for calculating holidays

https://www.yasumi.dev

Other

1.04k stars 152 forks source link

Closed fezfez closed 3 years ago

fezfez commented 3 years ago

Remove faker due to https://marmelab.com/blog/2020/10/21/sunsetting-faker.html (wont be compatible with php 8) (i added the used method on yasumi)

Tests are now working on php 8.

friendsofphp/php-cs-fixer is not compatible with php 8 so i have update deps via composer update --ignore-platform-reqs (why dont use phpcbf ?)

It will be nicer if github action could run the unit tests

stelgenhof commented 3 years ago

Thanks for this! I haven't yet had the time to check with PHP8.

I haven't used phpcbf as I had some bad experience with tools automatically fixing code: introducing more issues than expected :).

As for github actions, already TravisCI and StyleCI are configured. Is there anything you see missing that Github Actions can do better?

Cheers! Sacha

stelgenhof commented 3 years ago

@fezfez I'd like to merge your PR, however there are some issue with the code style. Can you reformat your code and commit again? Thanks!

fezfez commented 3 years ago

@stelgenhof fixed ! :)