search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Calculation for easter-date is either for orthodox or for western church #241

Closed heiglandreas closed 3 years ago

heiglandreas commented 3 years ago

Hey. I stumbled over your lib via a tweet and I checked how you solved the issue with different calendars and different easter-calculations. And stumbled over the fact that you are using only one easter-calculation. I didn't so far dig too deep into it but from what I know so far there is a slight difference - sometimes.

I will check that and add some tests to make sure whether it works correctly or needs a bit of improvement.

github-actions[bot] commented 3 years ago

Since this issue has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.