search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Mistyping in SouthKorea Provider #254

Closed barami closed 3 years ago

barami commented 3 years ago

Hi.

In SouthKorea provider src/Yasumi/Provider/SouthKorea.php, LUNAR_HOLIDAY constant has mapping table for 'seollal' and it has entry for year 2039, but date value is year 2037.

We should change 2039-1-24 instead of 2037-1-24.

Thanks.

stelgenhof commented 3 years ago

@barami Thank you very much for spotting this! I will make a correction.

stelgenhof commented 3 years ago

Fixed in the dev branch (Targeted for the 2.5 release).