search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Create Argentinian holidays provider. #264

Closed nedSaf closed 2 years ago

nedSaf commented 2 years ago

Update

ScreenShots

(This is a system we use for work logging, we pull the holidays into the work calendar) 2021-11-18 12 21 21 2021-11-18 12 22 12

Next

TB

3h

stelgenhof commented 2 years ago

Thanks @nedSaf for your work! Nice to have a another country added. Please do not forget to add unit tests.

nedSaf commented 2 years ago

Update

ScreenShots

Unit test result

Screen Shot 2021-11-19 at 11 52 55

Holiday names in English

2021-11-19 11 59 27

Review

@stelgenhof This is ready for your review.

/cc @mariano-dagostino

nedSaf commented 2 years ago

Fixing tests...

stelgenhof commented 2 years ago

@nedSaf You may want to check your tests as some of them are failing.

nedSaf commented 2 years ago

@stelgenhof I fixed all the tests, ready for your review :)

nedSaf commented 2 years ago

@stelgenhof Fixed your comments, with one comment from me ^^

nedSaf commented 2 years ago

Pushed a fix.

stelgenhof commented 2 years ago

@nedSaf Did you have a chance to look at my last comment? Thanks!

nedSaf commented 2 years ago

@stelgenhof Hey, I did push a fix after your comment, https://github.com/azuyalabs/yasumi/pull/264/commits/233f9d404e5f4f5f71eb20575805b5647dd4d0d0

I think that will cover the case you mentioned before, if not, please let me know.

nedSaf commented 2 years ago

@stelgenhof any updates?