Christmas day in Spain - Githubissues

azuyalabs / yasumi

The easy PHP Library for calculating holidays

https://www.yasumi.dev

Other

1.04k stars 152 forks source link

Christmas day in Spain #267

Closed sylvaincombes closed 2 years ago

sylvaincombes commented 2 years ago

In Spain, when christmas is on a sunday (as it will be in 2022), the holiday will be on the monday 26/12, I will propose a PR to update this behaviour.

stelgenhof commented 2 years ago

@sylvaincombes Is this because of a recent change in regulations or has this been incorrect in Yasumi all the time?

sylvaincombes commented 2 years ago

After thinking a little more about it :

It has been said to me by a native one as a general rule
But searching online I didn't find precise clear confirmation of that rule
I think maybe we should handle it better like some case where I saw keys like "substituteHoliday:christmasDay" and let Christmas on 25/12
If we can have some help by spain natives it would be great

github-actions[bot] commented 2 years ago

Since this issue has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.

github-actions[bot] commented 2 years ago

Since this issue has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.