search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Belgium: easter & pentecost are not public holidays #279

Closed happyDemon closed 2 years ago

happyDemon commented 2 years ago

marked them as observance. They're not on the wiki page that's used as source

stelgenhof commented 2 years ago

@happyDemon Thank you for the correction. Do you perhaps know of another official source that indicates these holidays are only observed?

Furthermore, your PR does not include any unit test. Please refer to this documentation page for details on how to contribute to this project: https://www.yasumi.dev/docs/contributing/

Cheers! Sacha

happyDemon commented 2 years ago

@stelgenhof I updated the tests and mentioned the adjustments in CHANGELOG.md.

https://werk.belgie.be/nl/themas/feestdagen-en-verloven/feestdagen It's in dutch, but under Welke zijn de wettelijke feestdagen they include a list of 10 paid holidays. It's the same list as wikipedia has :) so the wikipedia source is up to date.

stelgenhof commented 2 years ago

@happyDemon You may want to check your tests, as some are failing.

github-actions[bot] commented 2 years ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.