search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Netherlands Liberation day is only an official holiday every 5 years #280

Closed DRoet closed 2 years ago

DRoet commented 2 years ago

More info here:

https://www.timeanddate.com/holidays/netherlands/liberation-day#:~:text=Is%20Liberation%20Day%20a,Netherlands%20every%205%20years.

Let me know if there is anything else to add.

stelgenhof commented 2 years ago

Thanks for the PR! However your code is failing some of the CI checks and also you haven't provided any unit tests. Please check the Contribution guidelines for more details.

DRoet commented 2 years ago

I added test cases for the holiday type and ran php-cs-fixer, not sure if it is okay to hardcode the years but there isn't really a way to currently generate a random year every X years as far as I could tell.

stelgenhof commented 2 years ago

@DRoet The checks have been rerun however still some errors with the unit tests. Have you checked locally the tests run successfully?

DRoet commented 2 years ago

@stelgenhof My bad I must've missed that locally, should be fixed now.