Closed kl3sk closed 2 years ago
Hi @kl3sk Thank you very much for noting this. I will make a correction accordingly.
Hi @kl3sk I've made a fix for this, which you can find in this branch: https://github.com/azuyalabs/yasumi/tree/pentecost-monday-france.
Hi @kl3sk Can you let me know if the fix I made addresses your issue? Thanks!
Fixes merged to the develop
branch.
Hello @stelgenhof,
Thank you for the update.
I did yet found time to test. I'll come back when I can test it on my project.
Hello @stelgenhof sorry for the late time.
I tried with @dev-develop
and found that return false
for $yasumi->isHoliday(new \DateTime('2022-06-05'))
that is the intended behaviour.
But ! It look likes @master
(eg: v2.5.0
) returns the same.
Edit: It look like the date is wrong, on 2022 pentecost is on 2022-06-05 (05/06/2022 in French format). With that I try this (same result)
Method used : `Yasumi::isHoliday()` | |
On: v2.5.0 | On: dev-develop |
![image](https://user-images.githubusercontent.com/2953145/197539337-deb05e2a-852a-45e5-9a84-a876b4a83204.png) At least should be `true` and `false` | ![image](https://user-images.githubusercontent.com/2953145/197539520-59109868-1db2-4a51-a66e-9079e9cad6e0.png) Should be `false` and `false` |
Of course these are two different screenshots 😉
Hello,
As I know since 2004 this not a holiday anymore.
This day should not be count as one or may be optional.