search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Update Juneteenth with observed dates #282

Closed tylershuster closed 1 year ago

stelgenhof commented 2 years ago

Hi @tylershuster Thanks for the PR! Can you please add some unit tests? Please see also: https://github.com/azuyalabs/yasumi/blob/develop/CONTRIBUTING.md Thanks!

tylershuster commented 2 years ago

Will do. Sorry about the commit history; I'll clean that up. I'm a little confused about the existing unit tests because it seems to already test for the change I added! (minus the "(observed)" portion)

tylershuster commented 2 years ago

Please pardon my tardiness. Things seem to be in order, so please review.

stelgenhof commented 2 years ago

@tylershuster Reran the checks and there seem to be some code style issues.

stelgenhof commented 2 years ago

@tylershuster Can you check once more your PR as there some minor errors? I'd like to include this fix in the next release I am planning. Thanks!

tylershuster commented 2 years ago

@stelgenhof I think the style is fine now — PHPCS doesn't throw any errors.

tylershuster commented 2 years ago

Thanks for the feedback. I think those issues are cleaned up. I tried to pattern it after an existing substitute holiday

tylershuster commented 1 year ago

Failure seems...incorrect

stelgenhof commented 1 year ago

The unsuccessful checks are not directly related to this PR. I will merge it and resolve these afterwards.