search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Add Holiday for Cyprus #285

Closed bkintanar closed 1 year ago

bkintanar commented 2 years ago

Fixes: https://github.com/azuyalabs/yasumi/issues/284

stelgenhof commented 2 years ago

@bkintanar I think so far it looks good (the tests are green :+1: ) Are these all of the national holidays of Cyprus?

bkintanar commented 2 years ago

@stelgenhof no. easterTuesday is a bank holiday. Should it be removed?

stelgenhof commented 2 years ago

@bkintanar It can stay, as long as it has the appropriate category. Generally, for each country, all of the official, national holidays should be included in a provider. Any other holidays can of course be added as well.

stelgenhof commented 2 years ago

@bkintanar Looking at your PR once more, I noticed that (from the list on https://en.wikipedia.org/wiki/Public_holidays_in_Cyprus) Easter Sunday seems to be missing. Also a number of unit tests for some holidays are not present. Please add unit tests for all the holidays defined by the provider.

github-actions[bot] commented 1 year ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.