search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Add National Day of Mourning for Australia #288

Closed FuzzyWuzzyFraggle closed 1 year ago

FuzzyWuzzyFraggle commented 2 years ago

Added new national public holiday for Australia in commemoration of Queen Elizabeth II Based on recent PR by freshleafmedia for UK holiday

FuzzyWuzzyFraggle commented 2 years ago

The failures appear to be related to the UK test cases where the holiday type has changed from TYPE_OBSERVANCE to TYPE_BANK but the test cases do not take this into account. This would need to be fixed by an additional PR?

stelgenhof commented 2 years ago

@FuzzyWuzzyFraggle Yes indeed there are some errors with the UK tests. I will fix those shortly.

stelgenhof commented 2 years ago

@FuzzyWuzzyFraggle The UK tests have been fixed, so you may want to rebase your branch. (Note: it possible some failures pop up as tests are randomized and maybe not all cases are covered properly).

github-actions[bot] commented 1 year ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.