azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Adjust naming of Australian public holiday from Queen's Birthday to King's Birthday #315

Closed FuzzyWuzzyFraggle closed 1 year ago

stelgenhof commented 1 year ago

@FuzzyWuzzyFraggle Thank you very much for the PR. I think it is better to make the name changes time dependent, i.e. being able to see this name change as part of its timeline. Since it is an official event we want to track that in in time.

Meaning, technically speaking it is not a simple name change: rather it is a significant event that occurred which we like to record as such.

FuzzyWuzzyFraggle commented 1 year ago

@stelgenhof are you proposing that we leave the current implementation of the Queen's birthday intact, and add in a finish date, and create a brand new holiday for the King's birthday with a start date?

The underlying legislation in most of the jurisdictions that this holiday is observed have it as a generic holiday (admittedly they rever to it as the Sovereigns birthday, not the Monarchs birthday) and the update is purely a naming change

https://legislation.nsw.gov.au/view/html/compare/2012-07-06/2023-01-13/act-2010-115 https://www.legislation.qld.gov.au/view/whole/html/inforce/2017-06-05/act-1983-018 https://content.legislation.vic.gov.au/sites/default/files/ad24ad2c-06f2-3ae3-b0ce-1fcd9b5f61a0_93-119aa026%20authorised.pdf https://www.legislation.nt.gov.au/en/Legislation/PUBLIC-HOLIDAYS-ACT-1981

stelgenhof commented 1 year ago

@FuzzyWuzzyFraggle Yes indeed. That would allow to go back in time. I am aware that many using Yasumi have no such need and in this case it's only a name change. However, I know there are use cases where you would like to go back in time to get the list of holidays as it was then.

github-actions[bot] commented 1 year ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.