search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Fix, Provider\Germany: Pentecost is not an official holiday - except in Brandenburg #334

Closed fbett closed 7 months ago

fbett commented 7 months ago

Hi,

Pentecost was originally removed from the list of general holidays in #100. That's because pentecost is not an official holiday (until today) - except in Brandenburg.

I don't know why, it was added again in #225.

So i don't remove pentecost from the list of general holidays again, but it is generally marked as TYPE_OTHER.

stelgenhof commented 7 months ago

Hi @fbett Thank you for catching this. I am also not sure what the correct type should be as different developers have committed different changes in the past :) Assuming yours is correct, I have enabled the workflow actions. There is an issue though with a missing test, which you can see here: https://github.com/azuyalabs/yasumi/actions/runs/8523362013/job/23391036796?pr=334#step:9:312

Another error relates to the coding style. I will have a look at that.

Thanks!

fbett commented 7 months ago

Hi @stelgenhof, Thanks a lot for your feedback. You are right, there was another test i missed. It's updated now. I raised the memory_limit on my local machine to run all the tests.

stelgenhof commented 7 months ago

@fbett I have fixed the code styling issues. Please rebase your branch. If all goes well, we can then merge your PR :)