azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

Added AbstractProvider::getHolidaysOfType #4

Closed gisostallenberg closed 9 years ago

gisostallenberg commented 9 years ago

this makes it possible to get only Holidays of a certain type. This makes it possible to get 'national holidays' as mentioned in the Composer description

stelgenhof commented 9 years ago

Thank you for this! This is certainly something missing now in Yasumi. However, I was thinking making something similar to what PEAR Date_Holidays is using: Filters. That seems to be a very flexible solution.

stelgenhof commented 9 years ago

I just released v1.0.0 of Yasumi, which includes filters. This allows you to filter holidays to only get 'national' holidays as you requested. :)

gisostallenberg commented 9 years ago

Thanks for adding this. Nice feature.

stelgenhof commented 9 years ago

Glad you like it! If you have any more wishes, ideas please create an issue :). What other countries would you like to see added first?