azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

China #42

Closed splitice closed 4 years ago

splitice commented 8 years ago

Probably the most populous missing country. And one of the most disruptive public holidays for shipping (Chinese New Years)

I personally have no need for it at this stage, just thought it perhaps belongs on the TODO list.

stelgenhof commented 8 years ago

Yes, I know. I was working on the holidays for Taiwan (similar to the Chinese ones). The library is based on arithmetic calendars. However some countries/cultures apply calendars that are not arithmetic. There do have some kind of algorithm but very complex.

So definitely something I'd like to have but will take a while before figuring that one out. I'll add it to the TODO list :)

AGDholo commented 5 years ago

Some holiday dates in China will change slightly with the date of the weekend, and someone may need to manually maintain it at regular intervals.

github-actions[bot] commented 4 years ago

This issue has been open 60 days with no activity. Please remove the stale label or comment, or this will be closed in 10 days.