search

azweb76 / node-rpmbuild

RPM build package for node.
MIT License
2 stars 8 forks source link

fix rpmbuild under shells that don't support {} expansion #2

Closed seangarner closed 10 years ago

seangarner commented 10 years ago

Creating the rpmroot directories used {} expansion which relies on the shell supporting it. Node always seems to use /bin/sh in linux and in ubuntu that's a symlink to dash not bash.

I've modified it to do the expansion in js so which shell is used doesn't matter.

azweb76 commented 10 years ago

Thanks Sean. Pushed change to npmjs.org. v0.0.22.

seangarner commented 10 years ago

Awesome, thanks Dan. On 17 Jun 2014 19:27, "Dan Clayton" notifications@github.com wrote:

Thanks Sean. Pushed change to npmjs.org.

— Reply to this email directly or view it on GitHub https://github.com/azweb76/node-rpmbuild/pull/2#issuecomment-46346189.