azymohliad / anki-sonaveeb

Anki addon for Estonian learners
https://ankiweb.net/shared/info/1005526508
GNU General Public License v3.0
4 stars 2 forks source link

feat: Add additional fields to Anki cards #2

Closed s10 closed 1 day ago

s10 commented 1 week ago

Add "Word ID", "Definition", and "Examples" fields to Sõnaveeb notes Add an option to search in full Sõnaveeb (unif) and Keeleõppija Sõnaveeb (lite) Add language level to tags, if the word comes from Keeleõppija Sõnaveeb Add an option to choose between different lexemes of one homonym

Update card templates to display the new content Modify UI to handle the additional fields

azymohliad commented 1 week ago

Thanks for the contribution! The diff looks very clean, pleasure to review. The update path for existing decks seems to be handled well. I haven't tested it yet, will try to do it in the next couple of days.

azymohliad commented 1 week ago

Hey, so I've tested it and everything seems to work well.

I'm happy to merge it now. But I don't think most users would want those extra fields by default on their cards (for those who only want to study translations, definitions and examples are unnecessary noise). So just FYI, before creating a new release on Anki Web I plan to add a settings page, where users would be able to select what they want to see on their cards with simple checkboxes.

I wanted to add the settings page anyway, because some users asked me for an easy option to enable backward or forward cards only (but not both). But these extra fields is a good extra reason to do it. Hopefully I'll do it this weekend.

I will also tweak the UI of the word info preview, because it's a little less readable now with this extra info.

You marked it as a draft. Do you plan to do anything else here?

s10 commented 1 week ago

I have almost finished creating a follow-up with the following features:

I planned to implement another feature:

For me, learning a word without context is almost pointless because simple work-translation cards lack the information needed to integrate this word into the memory.

an easy option to enable backward or forward cards only (but not both)

It would be indeed a nice thing to have. Currently, I work around this by burying translation->word cards.

Screenshot 2024-11-12 at 21 16 19 Screenshot 2024-11-12 at 21 15 56 Screenshot 2024-11-12 at 21 16 07
azymohliad commented 1 week ago

Oh, wow, ok, sounds good. I'll wait for you to finish it then.

Add hidden word_id field to all cards and, with that information, allow the creation of unique cards for different homonyms (e.g. 'tee' as 'a road' and 'tee' as 'a tea' or the same for või, palk, etc).

Yeah, that seems like a good idea.

Currently, I work around this by burying translation->word cards.

You could also work this around by creating a new note type named "Sõnaveeb Custom" based off of "Sõnaveeb Basic" ("Tools -> Manage Note Types" in the desktop app), and then removing one of the two card types from it. It's not yet documented anywhere, but if "Sõnaveeb Custom" note type exists, it will have a higher precedence than the default one (code). This way you won't need to do anything after you add cards. But with the addition of the settings page I'll probably make custom note type selection more visible and explicit.

s10 commented 2 days ago

@azymohliad , I addressed all suggestions.

azymohliad commented 1 day ago

Thank you! I want to try a few tweaks to the UI, probably this weekend, and then will release it.