Closed wab closed 6 years ago
I think defaulting to div
elements would be a smarter default. I think 'opting into' using more semantic elements makes sense. I am using const MyCell = Cell.withComponent('div')
in a lot of places.
Personally I like clean-tag and styled-system but think it‘s inclusion into this library goes beyond being built with styled-components. However I would love the feature!
I'm happy to switch to div
. This library grew out of a codepen I wrote a while ago, and I used section
there because it made sense in that case. Happy to accept a PR to change to div
. Might be a breaking change though (which is fine).
:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Just wondering why you choose to fix the rendered tag of the cel component to this semantic one :
<section>
. Perhaps a simple<div>
would have been a less opinionated tag ...Nice feature to add could be offer tag modification with a new Cell component property, for exemple using
clean-tag
lib of styled-system (https://github.com/jxnblk/styled-system/tree/master/clean-tag) ...Would you accept a pull request on this point ?