azzamsa / islam

Islamic library for Rust
GNU General Public License v3.0
17 stars 4 forks source link

Wrong current salah and remaining time before Fajr #6

Closed rynidja closed 1 year ago

rynidja commented 1 year ago

Salam, While testing late night and after midnight I found that: 1- On a new day before fajr, instead of having current salah as Isha it is Dohr. 2- Before midnight, the remaining time of fajr is wrong. [edit: I removed fixes since there is a pull request]

azzamsa commented 1 year ago

@rynidja @moanrisy Would you like to try https://github.com/azzamsa/islam/releases/tag/v3.0.0 and report the result?

The issue is covered by the test here

azzamsa commented 1 year ago

@rynidja @Moanrisy I have added more coverage here https://github.com/azzamsa/islam/blob/master/src/salah/times.rs#L548-L566

Pretty sure the mentioned bugs are covered.

Thank you for reporting the bugs! :heart:

rynidja commented 1 year ago

I did some testing.

azzamsa commented 1 year ago
  • Currently it's 2023-09-02 00:05 and next prayer is "FajrTomorrow at 2023-09-03 04:47:26"

OH, Yes. It should be Fajr at 2023-09-02 04:47:26 You can file an issue regarding this.