azzazello / mega-isp

Automatically exported from code.google.com/p/mega-isp
0 stars 0 forks source link

led pin numbers hard-coded in setup() #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Simple fix, the pin numbers for the leds are hard-coded in setup(). They should 
be changed to 
used the pin definitions above so that it is possible to use different pin 
assignments.

Change:
void setup() {
  // 19200?
  Serial.begin(19200);
  pinMode(7, OUTPUT);
  pulse(7, 2);
  pinMode(8, OUTPUT);
  pulse(8, 2);
  pinMode(9, OUTPUT);
  pulse(9, 2);
}

To:
void setup() {
  // 19200?
  Serial.begin(19200);
  pinMode(LED_HB, OUTPUT);
  pulse(LED_HB, 2);
  pinMode(LED_ERR, OUTPUT);
  pulse(LED_ERR, 2);
  pinMode(LED_PMODE, OUTPUT);
  pulse(LED_PMODE, 2);
}

Original issue reported on code.google.com by whosawha...@gmail.com on 28 Jul 2009 at 9:15

GoogleCodeExporter commented 9 years ago
Fixed in 
http://code.google.com/p/mega-isp/downloads/detail?name=ArduinoISP.04.zip

Original comment by rsb...@gmail.com on 25 Jun 2011 at 3:38