azzeloof / supercon-2022-badge-vm

GNU General Public License v3.0
0 stars 1 forks source link

Refactor for Earlier Python Release? #2

Closed MS3FGX closed 1 year ago

MS3FGX commented 1 year ago

I see you're making extensive use of the Python 3.10 match case, which certainly makes sense for project like this, but I wonder if requiring the latest release is going to give some people problems at Supercon? It seems that many Linux distros are still using 3.8/3.9, and that assumes you're using the latest release anyway. I wouldn't be surprised if some people only have 3.7 when they show up.

Understanding that it would be a hassle, is there anything in the code that would prevent us from just replacing match case with if statements so we can get wider Python compatibility?

hexagon5un commented 1 year ago

Submitted a couple pull requests that implement this.

One is really simple, and then I went overboard on the assembler. :)

You can pick/choose.

azzeloof commented 1 year ago

Good call, and thanks @hexagon5un for taking care of it!