search

azzurris / git-repo

Automatically exported from code.google.com/p/git-repo
Apache License 2.0
0 stars 0 forks source link

repo incorrectly runs pager #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by Jean-Baptiste Queru <jbq@google.com> on Tue Mar 31 21:02:35 PDT 2009
Source: JIRA REPO-19

The repo script uses pager, and inherently will produce control character
(coloring) to standard output, even if the output is redirected to another
pipe or script.

This is because the script checks for the terminal presence on FD 0, and in
case of redirection FD 0 is still attached to the terminal.

.repo/repo/pager.py needs to be modified to fix this, replacing isatty(0)
with isatty(1). (Probably, it should be not os.isatty(0) or not os.isatty(1))

(see also http://b.android.com/2004 for original issue)

Original issue reported on code.google.com by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:09

GoogleCodeExporter commented 9 years ago 
Comment by Shawn Pearce <sop@google.com> on Wed Apr 01 07:27:48 PDT 2009

Fixed by https://review.source.android.com/9453 (repo 1.6.4)

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:10

GoogleCodeExporter commented 9 years ago 
Update by Shawn Pearce <sop@google.com> on Wed Apr 01 07:27:48 PDT 2009

Fixed in version 1.6.4.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:10