azzy9 / plugin.video.lbryplus

A Kodi plugin for accessing LBRY & Odysee content
GNU General Public License v2.0
5 stars 0 forks source link

Upcoming videos : add airing time and switch for disable #7

Open karlo2105 opened 6 months ago

karlo2105 commented 6 months ago

Lbryplus shows upcoming videos on top in recent tab. It would be great to add switch to disable such feature because it distorts latest uploaded videos. With upcoming videos enabled, it would be interesting to add airing schedule time such as in upcoming tab on Odysee. Below you can find upcoming videos error message.

imgpsh_fullsize_anim

azzy9 commented 6 months ago

Hi, could you please post a channel that puts upcoming videos in the recent section of the plugin. The channels I have subscribed to do not do this.

karlo2105 commented 6 months ago

@azzy9

https://odysee.com/@RT:fd
https://odysee.com/@RTFRANCE:a
https://odysee.com/@Jean-Jacques-Crevecoeur:f
https://odysee.com/@Kairospresse:0

Even, some events which had been aired a couple of months ago are displayed on top of recent tab. In this case @Kairospresse channel, two parts of conference are displayed on top [Conférence] Multiversité populaire. Below you can find a source.

https://odysee.com/$/search?q=multiversit%C3%A9%20populaire

Is there a chance to add number of views, likes and comments such it has been introduced with latest Youtube ?

Thanks ;-)

azzy9 commented 6 months ago

Thak you @karlo2105, I can confirm that the [CONFÉRENCE] videos are at the top when they shouldn't be, I would say this is the priority to see what is causing this before looking into upcoming videos. I will have a look when I have time.

azzy9 commented 6 months ago

Just a note to myself when looking at this later on: query = {'page': page, 'page_size': items_per_page, 'order_by': 'release_time', 'channel_ids': channel_ids, 'not_tags': ['c:scheduled-livestream','c:scheduled:hide']}

karlo2105 commented 5 months ago

@azzy9 Despite having upcoming disabled, programmed video still appears in recent tab for channel @kairospresse as you can see in attachment. Normally, it shall be displayed in recent tab only if upcoming is enabled in settings. IMG_20240412_001147

azzy9 commented 5 months ago

Thankyou @karlo2105, now filtered c:scheduled:show tag to remove it

karlo2105 commented 5 months ago

@azzy9 Since you updated addon, programmed event from @kairospresse isn't listed anymore in recent tab no matter upcoming is enabled or disabled. When i go to followed channels tab @kairospresse, programmed event is listed even with disabled upcoming switch. Normal behaviour shall be with upcoming enabled to show programmed videos in recent tab and followed channel tab on top. Upcoming disabled shall hide programmed videos display in recent tab and followed channel tab.

On the other side, i also noticed, recent videos from channels @RTenfrancais and @RTFRANCE aren't listed anymore in recent tab. However those two channels videos are listed on Odysee website. Lbryplys 0.6.1 lists @RTenfrancais and @RTFRANCE videos in recent tab.

azzy9 commented 5 months ago

I have removed the filtering by tags and copied Odysee by filtering if it has a source or not instead, so should be seeing the same videos now

karlo2105 commented 5 months ago

@azzy9 Thanks for update. It fixes listing for two channels above in recent tab and it hides programmed event for @kairospresse However, upcoming enabled feature doesn't show scheduled event when turned on.

You can see on the top of this channel upcoming tab which can be displayed or hidden. https://odysee.com/@Kairospresse:0

azzy9 commented 5 months ago

@karlo2105 could you check if the latest commits fix the issues in the upcoming tab?

karlo2105 commented 5 months ago

@azzy9 I updated addon. Upcoming tab appeared. I don't know whether or not it's related to upcoming enabled feature. However, currently there are not any programmed events in my following channels so i can't check it but as soon as it appears i shall test it.

karlo2105 commented 5 months ago

@azzy9 There is one programmed event from @kairospresse channel which is displayed on Odysee website as you can see below. Abonnements means Subscriptions. imgpsh_fullsize_anim

Upcoming feature is enabled in addon. However, there isn't any announced event shown despite programmed video from Kairospresse as you can see on pictures below.

Recent tab Odysee Recent tab

Upcoming tab Odysee Upcoming tab

@kairospresse tab Odysee Kairospresse tab

azzy9 commented 5 months ago

Thankyou, I see where I am getting confused. Odysee does two different requests for different types of upcoming shows, one with the tag ["c:scheduled-livestream"] & has_no_source:true while the other has the tag ["c:scheduled:show"] & has_source:true. I would rather only do one request, But since Odysee does 2, I guess I will have to imitate them to get the same results.

azzy9 commented 5 months ago

Latest commit should fix it, but will not be able to test until there are listings for a upcoming livestream and a scheduled video at the same time

karlo2105 commented 5 months ago

Since i reset session, I am not able anymore to launch Lbryplus addon. It show only Home page with : Files, Playlist and Video addons.

I put in server address : https://api.na-backend.odysee.com/api/v1/proxy

You can find below in log

azzy9 commented 5 months ago

showing an error with plugin.video.zeltorix.vk.video saying it requires bs4 (BeautifulSoup4), for lbryplus it is only saying "Error getting plugin://plugin.video.lbryplus/". I am looking at trying to solve an issue with the 2 requests with upcoming, the proxy server doesn't like it and bans your ip for around 10 mins. even when I put a sleep there to delay it?

karlo2105 commented 5 months ago

@azzy9 It happened seldom in the past with lbry addon but it didn't last for longtime. Lbryio helped to solve issue with http://localhost:5279. Problem was android application didn't manage to sync wallet so it took a while to work on localhost with Lbry. Before I updated lbryplus addon, I already had same message. Is it general or only at my side ?

azzy9 commented 5 months ago

The odysee proxy seems all over the place and slow, I was thinking it was me using 2 query in succession, but now I keep getting the error randomly, and when it works it is slow. Even the site is having issues

karlo2105 commented 5 months ago

@azzy9 Odysee is back. Upcoming tab displays programmed video. IMG_20240420_004948

It would be nice to show channel's name too under folder icon. Is scheduled video intended to be shown in Upcoming tab only or shall it be shown on top in Recent and Following channel tabs too with switch enabled? If scheduled event is to be shown in Upcoming tab only, Upcoming enabled switch becomes worthless.

azzy9 commented 5 months ago

Scheduled video is only suppose to show in upcoming tab, the switch is mainly for me since it is a feature I don't use. I have had they opportunity to have an upcoming livestream and scheduled show to come up at the same time and fixed an issue with it in the latest commit, so it should be working like the site now. I shall see what I can do with the channel name when I get the chance.