azzy9 / plugin.video.rumble

Rumble Kodi Plugin with login and subscription functionality
GNU General Public License v2.0
24 stars 1 forks source link

Able to create multiple rumble favourite instances for same channel #40

Open Pi-MONSTER opened 3 months ago

Pi-MONSTER commented 3 months ago

Saving a channel which already is a rumble favourite results in a new favourite if the subscriber count has changed.

ie. for the popular channel "mylunchbreak" I have been able to create the following working favourites;

"[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]7,989[/COLOR] [COLOR yellow]Subscribers[/COLOR]" "[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]13,420[/COLOR] [COLOR yellow]Subscribers[/COLOR]" "[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]14,092[/COLOR] [COLOR yellow]Subscribers[/COLOR]" "[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]15,614[/COLOR] [COLOR yellow]Subscribers[/COLOR]"

I think there are more code lines doing this but the following two illustrate the effect

line 283 add_dir( video_title, BASE_URL + link, 4, images, info_labels, cat, False, True, play, { 'name' : channel_link, 'subscribe': True } )

line 444 video_title += '[COLOR palegreen]' + subscribers + '[/COLOR] [COLOR yellow]' + get_string(30156) + '[/COLOR]'

Just a minor problem I noticed.

Would also be nice if there was a way to easily edit the order of favourites.

azzy9 commented 3 months ago

Aye, favourites needs to be reworked as there is no unique identifier for them.