search

b-b-a / bba-power

1 stars 0 forks source link

Cannot create a Tender #111

Closed ghost closed 12 years ago

ghost commented 12 years ago

I have been unable to create a Tender for a Contract. No error is produced but the insert does not appear.

Tag BBA-Power-V3.0b pinpoints the version to be fixed please. This is a showstopper for go live.

If necessary remove the supplier contact field as there are none at present. Or make it Not Required for now. (I am assuming it is the changes for the supplier contact that have caused the problem - should have tested it earlier).

shaunfreeman commented 12 years ago

I have done a 'fix' on this but it needs improving as I had to take out the error callbacks. Also tried to apply to the commit to the tagged commit but I can't seem to get the hang of it, I cannot get push it to github. so I had to apply it as normal. I will try to look into why I cannot push to the tag.

ghost commented 12 years ago

I guess it will require a branch. So instead of "master" we will need a "BBA-Power-V3" branch. I do this with "eddie" - check out the Tag, create a new branch "BBA-Power-V3" and commit the changes in it and push. I will then pull the branch.

On 08/03/2012 14:07, Shaun Freeman wrote:

I have done a 'fix' on this but it needs improving as I had to take out the error callbacks. Also tried to apply to the commit to the tagged commit but I can't seem to get the hang of it, I cannot get push it to github. so I had to apply it as normal. I will try to look into why I cannot push to the tag.

Reply to this email directly or view it on GitHub: https://github.com/b-b-a/bba-power/issues/111#issuecomment-4391739

ghost commented 12 years ago

I have changed this back to FixNeeded - we have to be able to create and work on multiple versions and this needs to be a fix to the version that is in BBA - let me know if you want to talk this over. E (it is working in the "master" versioin I have just pulled.)

shaunfreeman commented 12 years ago

I have now fixed this and created a new branch for version 3.0b that's we're the fix is now.

Sent from my iPad

On 9 Mar 2012, at 15:40, epounce reply@reply.github.com wrote:

I have changed this back to FixNeeded - we have to be able to create and work on multiple versions and this needs to be a fix to the version that is in BBA - let me know if you want to talk this over. E (it is working in the "master" versioin I have just pulled.)

Reply to this email directly or view it on GitHub: https://github.com/b-b-a/bba-power/issues/111#issuecomment-4418329

ghost commented 12 years ago

The Branch really needs to be "BBA-Power-V3" - is it possible to rename it? (So we can have furure "letter" versions on the V3 branch.) However, I have just spoken to Paul and I am trying to get him to take the current master branch into production - if he does then we will need to make that the "BBA-Power-V3" branch.
Re: "BBA-Power-V4" branch. That looks like it will be the version that includes "document storage" (i.e. don't do invoices for now). I will try to get to a discussion (initial spec.) document started soon.