Checking of duplicate Contracts

ghost commented 12 years ago

We need to implement checking of duplicate Contracts

contract_reference [soft] OR (_idClient AND dateStart) [soft]. General: This is "soft" validation - i.e. a warning is given to the user that they may be creating a duplicate entry and giving them the chance to continue with the insert/update or to abandon it,
They should be given some of the duplicate's information (there could be multiple duplicates of course!)

Specific: The duplicate contract ID and type, status, start_date, supplier.

(spec had contract_reference [hard] but there are duplicates in the system so we had better make this soft!)

shaunfreeman commented 12 years ago

moving this to V4 as it is a major change

shaunfreeman commented 12 years ago

was this to be on the edit contract form too? as I am enabling it for only new contracts at the moment.

ghost commented 12 years ago

Since they can edit the ref number and the start date we had better have it on both please.

Eddie Pounce Pounce Computer Services 01767 348186 http://www.p-cs.co.uk

On 20/09/2012 15:32, Shaun Freeman wrote:

was this to be on the edit contract form too? as I am enabling it for only new contracts at the moment.

— Reply to this email directly or view it on GitHub https://github.com/b-b-a/bba-power/issues/116#issuecomment-8730161.

shaunfreeman commented 12 years ago

this has been merged into 4.0 now

ghost commented 12 years ago

Thanks. This is looking good. Have added a couple of columns, changed a button label and made the check dependent on the contract type. Could you check that I have not done something silly please. It would be nice to drop back to the new/edit box on cancel but I am guessing that that would be difficult - is it?

shaunfreeman commented 12 years ago

I have had a look and all looks fine and dandy to me.

I will drop back to the new/edit box and no not difficult to do.

Sent from my iPad

On 26 Sep 2012, at 15:48, Eddie Pounce notifications@github.com wrote:

Thanks. This is looking good. Have added a couple of columns, changed a button label and made the check dependent on the contract type. Could you check that I have not done something silly please. It would be nice to drop back to the new/edit box on cancel but I am guessing that that would be difficult - is it?

— Reply to this email directly or view it on GitHub.

ghost commented 12 years ago

This is good. One thing - if I use "enter button (on the keyboard)" instead of pressing the "submit" it seems to bypass these checks and do the insert/edit. (Thought - will this be the case in other placed?)

ghost commented 12 years ago

Still occuring - add a new contract - use the same start date as another contract - press enter/return Record is added without checks. Soft error correct if "submit" button used via mouse.

shaunfreeman commented 12 years ago

Will have to look at this again. At the moment the soft error check is linked to the onClick event on the submit button, I think will have to use the onSubmit event instead. Oddly this doesn't happen on the client address check. Might have something to do with the file upload inputs as this changes the way the form is handled.

ghost commented 12 years ago

No other screens seem to react to "return" on keyboard - something I find frustrating but not a problem for most users. Can we just catch the "retun / enter" for now - sounds like the onSubmit event would be better but that will need changing everywhere to keep things consistent. Quick fix for now and submit a do it properly issue for later?

shaunfreeman commented 12 years ago

I am having difficulty in getting this fixed at the moment can't seem to get a handle on the onSubmit event as this form uses the uploader class which is different from the rest of the forms as it takes over the form and adds it's own event system :-(

I could try and disable the keyboard for this form as a quick fix.

ghost commented 12 years ago

Do you mean just stop the enter key working to submit it? They may need to type into the form! This would be OK as all the others don't allow the enter button.

shaunfreeman commented 12 years ago

Yes just stop the enter key submitting the form.

Sent from my iPad

On 16 Oct 2012, at 15:54, Eddie Pounce notifications@github.com wrote:

Do you mean just stop the enter key working to submit it? They may need to type into the form! This would be OK as all the others don't allow the enter button.

— Reply to this email directly or view it on GitHub.

b-b-a / bba-power

Checking of duplicate Contracts #116