search

b-b-a / bba-power

1 stars 0 forks source link

Document Upload Selection Boxes #151

Closed ghost closed 12 years ago

ghost commented 12 years ago

Document Upload seems to be working well. The field seems to be centred - please left justify to line up with the others. Also, please make the document name display area as wide as will fit.

shaunfreeman commented 12 years ago

Also, please make the document name display area as wide as will fit.

hope the new change fit this. wasn't too sure if you meant in the form dialog boxes or on the tab display.

ghost commented 12 years ago

Thanks for the quick response.

Re: "form dialog boxes or on the tab display" I was referring to the dialog boxes.

Re: "as wide as will fit" - This wasn't what I expected - I was expecting that the box would just be made wider to fill the right hand site of the table. However, having the whole right side might be a good idea if Paul is using such long names! But I suggest using the normal file input box layout for now though - it looks like a hastle to get the file name separate from the button but just show the file name above the button. (The type and # are not required nor are/is the headings as we are only dealing with a single file on upload.)

Other small things on edit contract dialog

Also, could you swap the Analysis Document & Termination Document fields in the contract display area so they match the order in the edit contract box please - it is really confusing to have them in a different order.

I am seeing the "show all..." for the docs when there is only one item in the storage area (and only one shows when "show all..." is selected).

Cheers

Eddie

Eddie Pounce Pounce Computer Services 01767 348186 http://www.p-cs.co.uk

On 13/06/2012 19:44, Shaun Freeman wrote:

Also, please make the document name display area as wide as will fit.

hope the new change fit this. wasn't too sure if you meant in the form dialog boxes or on the tab display.

Reply to this email directly or view it on GitHub: https://github.com/b-b-a/bba-power/issues/151#issuecomment-6309754

shaunfreeman commented 12 years ago

I have opted for a button and putting file name above it, hope this is ok all other fixes done too.

ghost commented 12 years ago

This I like. Two small changes if possible - not urgent. Can the label line up with the file name (see email example) and the file name have an empty box? There appears to be an extra "

 
" under the "Show all ..." that is spacing things out too much.

ghost commented 12 years ago

Great - that looks better. However, I tried putting in a JPG as a test.
On the Client Edit the save button did nothing - an error needs raising I assume. On the Contract Edit the save button gave an error but the text of the error was over other part of the boxes content - presumably an HTML change needed.

shaunfreeman commented 12 years ago

yes I need to get the styling correct here :-(