search

b-casey / OpenSMACX

A project to decompile SMAC/X to C++ with the long term goal of creating a full open source clone.
GNU General Public License v3.0
52 stars 4 forks source link

Saved game can use incorrect faction colors #13

Open b-casey opened 4 years ago

b-casey commented 4 years ago

The issue seems to be that if the scenario flag is set in a saved game, it doesn't reload the faction color palette if it's already loaded. What can happen is you are switching between multiple saved games, it can load a game with a previous games color scheme based on faction order.

The issue is present in load_game() where a saved games that has the scenario flag set will skip load_faction_art().

DrazharLn commented 4 years ago

This would be really nice for PBEM players :)

On Thu, 21 May 2020, 01:36 b-casey, notifications@github.com wrote:

The issue seems to be that if the scenario flag is set in a saved game, it doesn't reload the faction color palette if it's already loaded. What can happen is you are switching between multiple saved games, it can load a game with a previous games color scheme based on faction order.

The issue is present in load_game() where a saved games that has the scenario flag set will skip load_faction_art().

https://user-images.githubusercontent.com/10122115/82510791-163a8e00-9ad1-11ea-9e07-6419259c41b1.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/b-casey/OpenSMACX/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESXNWMPTVG3VH76S5MEFETRSRZPPANCNFSM4NGNR4KA .