search

b-casey / OpenSMACX

A project to decompile SMAC/X to C++ with the long term goal of creating a full open source clone.
GNU General Public License v3.0
52 stars 4 forks source link

Unused variable (talent soc effect not applied?) #33

Open DrazharLn opened 3 years ago

DrazharLn commented 3 years ago

base_psych is marked as WIP, so maybe you already know, but this looks like a bug:

(Variable val is unused).

https://github.com/b-casey/OpenSMACX/blob/b203ef4936499711a2a08dbe8f4d5e3827d32506/src/base.cpp#L889-L924

talents_fac and has_punishment_sphere are also unused in the same function.

b-casey commented 3 years ago

Yep, only about 25% of function is there. There is a large loop right where I stopped that variables are used in. Going to come back and finish this after cleaning up some drafts first. It's on my list of functions to complete for next release.

DrazharLn commented 3 years ago

Cool beans! Good luck!

On Sat, 30 Jan 2021, 19:06 b-casey, notifications@github.com wrote:

Yep, only about 25% of function is there. There is a large loop right where I stopped that variables are used in. Going to come back and finish this after cleaning up some drafts first. It's on my list of functions to complete for next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/b-casey/OpenSMACX/issues/33#issuecomment-770265312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESXNWKUDWGZUHJFFB7LERLS4RKFFANCNFSM4WYHKLCA .