b-com-software-basis / builddefs-qmake

QMake build script tools to manage cross platform project building and dependencies in development projects (also manages nsis installer, mac bundling...). Aims at providing Maven like dependencies management to C/C++ builds.
2 stars 4 forks source link

Avoid unecessary warning message relative to PROJECTDEPLOYDIR not being defined before inclusion of templatelibconfig.pri #12

Closed jim-bcom closed 1 year ago

jim-bcom commented 1 year ago

PROBLEM In our project we tend to often use default PROJECTDEPLOYDIR and thus we systematically get the folowing warning message:

:-1: warning: Project WARNING: PROJECTDEPLOYDIR may be defined before templatelibconfig.pri inclusion => Defaulting PROJECTDEPLOYDIR to /home/<username>/.remaken/packages/linux-gcc/<my defined INSTALLSUBDIR>/<my defined TARGET>/<my VERSION>. 

I reckon it serves a documentation purpose by easing the discoverability of this feature, but maybe we shouldn't get a warning for an expected behavior.

SUGGESTED SOLUTION The code is here.

warning("PROJECTDEPLOYDIR may be defined before templatelibconfig.pri inclusion => Defaulting PROJECTDEPLOYDIR to $${PROJECTDEPLOYDIR}. ")

-> Personnally I'm fine with the last solution: just make the warning a message like for INSTALLSUBDIR.

Thanks.

stefled commented 1 year ago

In order to reduce warnings messages during qmake and build, this warning has been change as a message, as well as other warnings in builddefs/qmake

cf commit 58a42eeac98ffd7b9ed05e1c7d360d0ab9418d0c

Will be available in next release 4.10.0

stefled commented 1 year ago

available in release 4.10.0