7 avoid changing user global state by setseed

b-cubed-eu / gcube

Simulation framework for biodiversity data cubes

https://b-cubed-eu.github.io/gcube/

Other

0 stars 2 forks source link

7 avoid changing user global state by setseed #36

Closed PietrH closed 7 months ago

PietrH commented 7 months ago

This PR fixes bug #24 and also makes strides towards #7 , we no longer use set.seeds() within the functions of this package. We still do for examples and unit tests. And as I understand it, this might still cause issues. I created a new issue for this: #37

I believe the remaining set.seed() calls are less problematic, so #37 is less urgent than #24 was.

PietrH commented 7 months ago

@wlangera ready for review, this PR combines both our changes and solves a merge conflict in DESCRIPTION.