b-fuze / deno-dom

Browser DOM & HTML parser in Deno
https://jsr.io/@b-fuze/deno-dom
MIT License
425 stars 47 forks source link

deno-dom-native throws error about explort Plug #131

Closed Sembiance closed 1 year ago

Sembiance commented 1 year ago
error: Uncaught SyntaxError: The requested module 'https://deno.land/x/plug/mod.ts' does not provide an export named 'Plug'
import { Plug } from "https://deno.land/x/plug/mod.ts";
         ^
    at <anonymous> (https://deno.land/x/deno_dom@v0.1.36-alpha/deno-dom-native.ts:1:10)

Looks like the Plug export stopped being available in version 0.5.2

If I manually change the import line to import { Plug } from "https://deno.land/x/plug@0.5.2/mod.ts"; then it works ok, so that could be a quick workaround.

nhrones commented 1 year ago

Same here on Windows10 W/latest Deno 1.29.4 I get the following error:

error: Uncaught SyntaxError: The requested module 'https://deno.land/x/plug/mod.ts' does not 
provide an export named 'Plug'
import { Plug } from "https://deno.land/x/plug/mod.ts";
         ^
    at <anonymous> (https://deno.land/x/deno_dom@v0.1.36-alpha/deno-dom-native.ts:1:10) 

I can run the examples with deno-dom-wasm and with deno-dom-wasm-noinit with no errors or issues.

Also, I've tried a few other deno libs recently that have produced this exact same error message about Plug. Yes the manual rollback to 0.5.2 worked for me also. Looks like Plugs1.0.0 release candidate was a major breaking change for many deno libs. The Plug docs show using dlopen now.

b-fuze commented 1 year ago

Thanks