search

b-fuze / deno-dom

Browser DOM & HTML parser in Deno
https://jsr.io/@b-fuze/deno-dom
MIT License
412 stars 48 forks source link

Add Packaging info to cargo.toml file ? #134

Closed reyman closed 1 year ago

reyman commented 1 year ago

Hi !

I'm trying to packaging Deno (finished) to use with Quarto project (work in progress) for GUIX system.

Quarto project use Deno-dom as dependencies https://github.com/quarto-dev/quarto-cli/blob/main/configuration#L12

Actually i have some problem to package Quarto into Guix package because "deno-dom" is defined as a virtual-manifest ...

Is there some possibility to add some package line to cargo.toml to facilitate future packaging with application ?

Thanks !

b-fuze commented 1 year ago

I'm not familiar with Guix, what would need to be done to solve your issue?

reyman commented 1 year ago

@b-fuze Guix work by importing "crates" from the official repository (https://crates.io/) perhaps it's possible to publish deno-dom ?

b-fuze commented 1 year ago

The reason that I wouldn't do that is because Deno DOM is not a Rust package. It has a Rust component, but it is primarily a TypeScript Deno library.

What I'd suggest instead is to look at the deno vendor command, and also grabbing the native binary from here if you're using the native Deno DOM backend.

reyman commented 1 year ago

Ok thanks for clarification, i understand why Deno Dom is not a Rust Package, this is more clear.

I cannot use directly Binary with Guix. This distribution is oriented to reproducibility, this is why everything is compiled from source.

I see source file seems already included/pushed into quarto cli ( https://github.com/quarto-dev/quarto-cli/tree/main/src/vendor/deno.land/x ) This is not a good pratice, so i will provide vendor directly from this repository.

I will look more in depth later