bump nwsapi to avoid global pollution?

b-fuze / deno-dom

Browser DOM & HTML parser in Deno

https://jsr.io/@b-fuze/deno-dom

MIT License

425 stars 47 forks source link

bump nwsapi to avoid global pollution? #151

Open cscheid opened 1 year ago

cscheid commented 1 year ago

While linting the bundled releases of quarto, we've noticed that deno-dom pollutes the global scope. We narrowed it down to nwsapi.js:367, etc.

The upstream nwsapi library has fixes for these. Would updating nwsapi be considered a bug in scope in deno-dom?

b-fuze commented 1 year ago

Yes, we can do this. I've actually already prepared this, but put it off because of some fixes that the NWSApi developer said were resolved were not actually resolved when I tested them locally.

But if it pollutes the global namespace less then I'm all for it.