How can this function return null?

b-fuze / deno-dom

Browser DOM & HTML parser in Deno

https://jsr.io/@b-fuze/deno-dom

MIT License

423 stars 47 forks source link

How can this function return null? #163

Closed pihentagy closed 5 months ago

pihentagy commented 6 months ago

https://github.com/b-fuze/deno-dom/blob/ee4e7d268f75fcf61b2d03679ef5f52b2aca5ff3/src/dom/dom-parser.ts#L17

Just curious how can it be null?

It will fail earlier, with other error.

b-fuze commented 5 months ago

@pihentagy good point, I have no idea why its signature says that it can return null... I thought that I might have found something in the spec saying so, but just seems like a mistake on my part. I resolved that in 3f6ca910d3c17231f7a3cfdf06979af468dda2f4

pihentagy commented 5 months ago

Thanks, that was quick. And needed a lot of test changes.

What is your release strategy (so when can one expect next release)?

b-fuze commented 5 months ago

I'm not following any particular release strategy currently since my updates are so sporadic. Probably sometime today or tomorrow I'll make a new release

b-fuze commented 5 months ago

As part of #164 I've already released this change in v0.1.47 to both deno.land/x and JSR so closing this