search

b-fuze / deno-dom

Browser DOM & HTML parser in Deno
https://jsr.io/@b-fuze/deno-dom
MIT License
412 stars 48 forks source link

NodeList return type #173

Closed turuslan closed 1 month ago

turuslan commented 2 months ago

Generic param T was not used

b-fuze commented 2 months ago

Thanks I missed that. This and #162 should close #4 and close #141

b-fuze commented 2 months ago

Can you fix the the type errors? Run

deno task type-check

to see what they are. Also, make sure you run deno fmt so that the formatting isn't off

turuslan commented 2 months ago

Sorry, I tried running deno task type-check, but it didn't report TS2322.

# macos
deno 1.45.2 (release, aarch64-apple-darwin)
v8 12.7.224.12
typescript 5.5.2
# docker
deno 1.45.2 (release, x86_64-unknown-linux-gnu)
v8 12.7.224.12
typescript 5.5.2
timreichen commented 1 month ago

Is there any way to have this implemented soon?

b-fuze commented 1 month ago

I can't commit to their branch so I can't fix the problems. @timreichen I saw that you created a PR, if you want to get your own PR merged I'm fine with closing this one

timreichen commented 1 month ago

I can't commit to their branch so I can't fix the problems. @timreichen I saw that you created a PR, if you want to get your own PR merged I'm fine with closing this one

I reopened my initial PR. PTAL.