search

b-fuze / deno-dom

Browser DOM & HTML parser in Deno
https://jsr.io/@b-fuze/deno-dom
MIT License
425 stars 47 forks source link

add a CI that checks formatting and run tests #87

Closed Hunam6 closed 2 years ago

Hunam6 commented 2 years ago

depends on #86, should be merged after

I didn't format the code on purpose to ensure that the CI really fails if the code isn't formatted.

Hunam6 commented 2 years ago

Can you run the CI to test it please?

Screenshot 2022-03-26 at 12 27 59

b-fuze commented 2 years ago

Hrm, the release plugin is failing... I'll have to remove that branch from the pull-request trigger, or can you do that?

Hunam6 commented 2 years ago

For now I've disabled testing on Windows because of this issue: https://github.com/b-fuze/deno-dom/runs/5753986401?check_suite_focus=true.

b-fuze commented 2 years ago

It not working on Windows is fine. I completely forgot that deno fmt runs on Markdown as well lol. I'll take out the native plugin building step and move it into its own GHA Workflow.

Otherwise, looks good. Thanks