New OSX path option - Githubissues

b-g / processing-sublime

A Sublime Text package for the programming language Processing

MIT License

448 stars 60 forks source link

New OSX path option #88

Closed ybakos closed 9 years ago

ybakos commented 9 years ago

Fixes #86, #81, #80.

Processing 3 installs processing-java in /usr/local/bin instead of /usr/bin. On OSX, this is a problem, because Sublime Text does not use the user's PATH. This can easily be addressed by installing the "Fix Mac Path" package, which all OSX users should probably install anyway, but it would be better to make the "out of box" experience for this package work without installing another package.

This PR adds osx platform-specific options for path. What's nice is that we declare it at the top level of the build system and all variants inherit it (no need to duplicate the option for all variants.)

@b-g This PR is to be merged to the develop branch as a demonstration to others for the PR process. You can merge it to develop, test it to make sure I'm not crazy, and then merge it to master.

PS. If I am being too serious with "process" just tell me to lighten up. :beer:

b-g commented 9 years ago

Many thanks! I see! I gave it a try ... it worked after I installed the brand new P3 beta 7.

The older version gave me this error:

/usr/bin/processing-java: line 2: /Applications/Processing.app/Contents/PlugIns/jdk1.7.0_55.jdk/Contents/Home/jre/bin/java: No such file or directory
[Finished in 0.0s with exit code 127]
[cmd: ['processing-java', '--force', '--sketch=/Users/bene/Dropbox (Personal)/Code/Processing/angle_slerp3', '--output=/Users/bene/Dropbox (Personal)/Code/Processing/angle_slerp3/build-tmp', '--run']]
[dir: /Users/bene/Dropbox (Personal)/Code/Processing/angle_slerp3]
[path: /Users/bene/.nvm/v0.10.40/bin:/Users/bene/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin]

I have no idea how to merge it on a different branch (still no github pro). Should we not simply try out any PR and then directly merge it to the master, why the via dev branch step? May I just merge it directly to master?

ybakos commented 9 years ago

Ok, I will test again with both v2 and different versions of v3.

Regarding the purpose of merging to development first, and then from development to master: This is really just "good habit." Where it is most helpful is when we have lots of changes (e.g. updates for Processing 3) and we want to collect them all in the development branch before merging them all at once to master.

To do this you first merge the pull request to the development branch using the GitHub web interface (the green button). Then, once you're happy, merge develop to master just like you did for PR #85 .

You can really do whatever you want. :)

b-g commented 9 years ago

Thanks! :) I'm learning + understood. Let's do it that way in future. Will merge it once you checked ...