search

b-g / processing-sublime

A Sublime Text package for the programming language Processing
MIT License
448 stars 60 forks source link

New OSX path option (revised) #89

Closed ybakos closed 9 years ago

ybakos commented 9 years ago

Note: This revised PR addresses the issue discussed in https://github.com/b-g/processing-sublime/pull/88.

This revision reorders the directories in the path option, to help insulate Processing 3 beta users from a problem that occurs if the old /usr/bin/processing-java still exists. Note that Processing 3b6 fixed this issue by deleting the old /usr/bin/processing-java, so this will never be an issue for new users anyway; but this helps our package users who may be using earlier betas, and who install new versions of Processing 3, without re-installing processing-java.

Fixes #86, #81, #80.

Processing 3 installs processing-java in /usr/local/bin instead of /usr/bin. On OSX, this is a problem, because Sublime Text does not use the user's PATH. This can easily be addressed by installing the "Fix Mac Path" package, which all OSX users should probably install anyway, but it would be better to make the "out of box" experience for this package work without installing another package.

This PR adds osx platform-specific options for path. What's nice is that we declare it at the top level of the build system and all variants inherit it (no need to duplicate the option for all variants).

ybakos commented 9 years ago

@b-g I closed the previous PR and have a new one. This should do it. I reinstalled the old usr/bin/processing-java as well as having usr/local/bin/processing-java and this now works as expected.

b-g commented 9 years ago

Thanks! Works! And merged to dev branch via the green button :)